Handle light account backup while on FiatPluginEnterAmountScene
#5358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jon-edge
force-pushed
the
jon/fix/light-acc-warning
branch
2 times, most recently
from
56a7510 to
58b819f
Compare
paullinator
requested changes
Nov 17, 2024
| @@ -85,6 +87,9 @@ export const FiatPluginEnterAmountScene = React.memo((props: Props) => { | |||
| throw new Error('disableInput must be 1 or 2') | |||
| } | |||
| const lastUsed = React.useRef<number>(1) | |||
| const account = useSelector(state => state.core.account) | |||
| const currentUsername = useWatch(account, 'username') | |||
| const [initUsername] = React.useState(account.username) | |||
There was a problem hiding this comment.
Since you're not changing the state, use useRef
Jon-edge
force-pushed
the
jon/fix/light-acc-warning
branch
from
58b819f to
b2b1c6a
Compare
paullinator
approved these changes
Nov 19, 2024
Jon-edge
force-pushed
the
jon/fix/light-acc-warning
branch
from
b2b1c6a to
d3d4778
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: